-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move houdini client code #516
Conversation
Task linked: AY-4916 Move Houdini client code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested successfully in Houdini with dev mode and build mode.
@iLLiCiTiT Also, I faced a problem with are there other solutions ? |
So if I understand it correctly, the plugin lives in core, but houdin settings are applied to it. In that case please make a copy of the plugin in houdini and remove |
Note that this is also true for harmony, after effects, photoshop, maya - they all have settings for this validator it seems but no dedicated plug-in. I wonder if this isn't a case that might be better suited to use |
Hello @moonyuet ,
I've resolved the conflicts and merged latest develop.
This PR should be working without other PRs as I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do another test around houdini, it doesn't hit any issue so far in my side.
…ub.com/ynput/ayon-core into chore/AY-4916_Move-Houdini-client-code
…916_Move-Houdini-client-code-settings-category
@MustafaJafar let's get those plugins in here similar to what happened in the Maya addon code move - just so we align the code style a bit - see the Maya PR and then do another test run. |
…code-settings-category Houdini: move houdini client code - Add Settings Category
After merging #536, this PR became aligned to the Maya PR. I tested my PR and everything seems to function as it used to before this PR.
Also, a lot of warnings which is really annoying because they are printed to the Houdini console.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do a simple test and looks good. I also tested to see if there is any issue with extract fbx as the log above shows the possibility of plugin being "disappeared" as it can't be found in the setting category but the extractor is still there and it doesn't cause the error on integrate.py
.
Thank you for your review.
Also, for reference. that log is just a warning about there are no settings for that plugin. ayon-core/client/ayon_core/pipeline/publish/lib.py Lines 337 to 350 in 242bc87
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did quick testst too, had a really quick look at the code (as quick as it can be with ~130 files changes).
Changelog Description
Move Houdini client code..
This is one more step towards splitting addons to their repos.
Additional info
python server_addon\create_ayon_addons.py --addon houdini
create_package.py
from Update create_package.py example-studio-addon#4 to<your-ayon-core-clone>/server_addon/houdini
and Run it.Additional info 2
I don't think that settings are applied correctly in the publish plugins.
Any advice are much appreciated.
Testing notes: